Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow plugins to be specified as direct file paths #36

Merged
merged 5 commits into from Apr 1, 2022
Merged

Allow plugins to be specified as direct file paths #36

merged 5 commits into from Apr 1, 2022

Conversation

jefferai
Copy link
Member

This contains two items:

  1. In pluginutil, allows a direct plugin path to be specified, along with a (required) checksum and (optional) hash method used to generate the checksum. This is via an option that then factors into building the plugin map, and some plugin launching changes to understand these types.
  2. In configutil, support for this new feature for KMS plugins. Additionally, the ability to specify this information within KMS blocks in HCL.

Tagging @jimlambrt for review, @calvn and @sgmiller mostly for heads-up.

@jefferai jefferai force-pushed the jefferai-plugin-files branch 2 times, most recently from 195c6c6 to d0f3cd6 Compare March 18, 2022 14:46
johanbrandhorst
johanbrandhorst reviewed Mar 20, 2022
View reviewed changes
configutil/file_plugin_test.go Outdated Show resolved Hide resolved
configutil/kms.go Show resolved Hide resolved
configutil/testplugins/aead/main.go Show resolved Hide resolved
pluginutil/pluginutil.go Outdated Show resolved Hide resolved
@jefferai @johanbrandhorst
Update pluginutil/pluginutil.go
858f8ea 
Co-authored-by: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>
jimlambrt
jimlambrt approved these changes Apr 1, 2022
View reviewed changes
Copy link
Collaborator

@jimlambrt jimlambrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

configutil/Makefile Show resolved Hide resolved
@jefferai jefferai merged commit 639f65c into main Apr 1, 2022
@jefferai jefferai deleted the jefferai-plugin-files branch April 1, 2022 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvn calvn calvn left review comments

@johanbrandhorst johanbrandhorst johanbrandhorst approved these changes

@jimlambrt jimlambrt jimlambrt approved these changes

@sgmiller sgmiller Awaiting requested review from sgmiller

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jefferai @calvn @johanbrandhorst @jimlambrt