fix kv builder out of bounds panic on single backslash #35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The KV Builder panics when attempting to process a single backslash. The KV Builder
add
method currently assumes that the provided string has at least two characters when attempting to check for an escaped@
(i.e.\@
). The proposed fix is to guard with a length check.In additional to the added unit test, this change was functionally tested with the Vault kv secret engine CLI.
Before change:
After change: