awsutil: add GetCallerIdentity to Create/Rotate #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds GetCallerIdentity to CreateAccessKey and RotateKeys. The latter is done simply by passing WithTimeout through to the inner CreateAccessKey on Rotate. As such, both paths are conditional on a non-zero WithTimeout option being given - this is to ensure that we don't try to immediately verify, which is likely to always fail.
jefferai
reviewed
Sep 17, 2021
jefferai
reviewed
Sep 17, 2021
This does the following: * Adds some comments for WithTimeout to RotateKeys and CreateAccessKey to explain exactly what these options do. * Removes the exponential backoff. Even with the quadratic-time backoff we're still probably looking at a number of seconds of delay that's probably unnecessary. Retrying every 1s should not generate that much traffic and only need to be necessary for a few retries.
|
@jefferai changes made, should be good to go! |
jefferai
approved these changes
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds GetCallerIdentity to CreateAccessKey and RotateKeys. The
latter is done simply by passing WithTimeout through to the inner
CreateAccessKey on Rotate. As such, both paths are conditional on a
non-zero WithTimeout option being given - this is to ensure that we
don't try to immediately verify, which is likely to always fail.