New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry extra handling #161
Retry extra handling #161
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not bad! I think we could clean up the interface a tad, and I left a comment about the retry trigger being a bool vs an error that I think we should consider.
Co-authored-by: Ryan Uber <ru@ryanuber.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Only minor tweaks regarding naming and logging, otherwise this seems solid. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚢
Sometimes a request can "succeed" but fail later and in order to retry the later things, we have to retry the whole request. This PR adds an option to pass a "response handler" to deal with this situation.
The tests were failing (some genuinely, some because of new vet rules)
Asana