Skip to content

Fix examples/basic/commons go package name #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

niulechuan
Copy link
Contributor

Fix examples/basic/commons go package name

Package name "commons" is more explicit in "commons" dir than "example".

@hashicorp-cla
Copy link

hashicorp-cla commented Sep 26, 2022

CLA assistant check
All committers have signed the CLA.

@niulechuan
Copy link
Contributor Author

Cc: @fairclothjm PTAL, thanks!

@fairclothjm
Copy link
Contributor

@niulechuan Hi, thanks for the PR! I wonder if it would make more sense to change commons->shared to align more with the other examples. See https://github.com/hashicorp/go-plugin/tree/master/examples/grpc/shared.

Also, don't forget to update the code examples in https://github.com/hashicorp/go-plugin/blob/master/docs/extensive-go-plugin-tutorial.md

@niulechuan niulechuan force-pushed the fix-example-basic-pkg-name branch from 486e055 to b578caa Compare October 12, 2022 09:18
Signed-off-by: Niu Lechuan <lechuan.niu@daocloud.io>
@niulechuan niulechuan force-pushed the fix-example-basic-pkg-name branch from b578caa to f836044 Compare October 12, 2022 09:29
@niulechuan
Copy link
Contributor Author

niulechuan commented Oct 12, 2022

@niulechuan Hi, thanks for the PR! I wonder if it would make more sense to change commons->shared to align more with the other examples. See https://github.com/hashicorp/go-plugin/tree/master/examples/grpc/shared.

Also, don't forget to update the code examples in https://github.com/hashicorp/go-plugin/blob/master/docs/extensive-go-plugin-tutorial.md

Absolutely!
Done

Copy link
Contributor

@fairclothjm fairclothjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fairclothjm fairclothjm merged commit 8fbac73 into hashicorp:master Oct 12, 2022
@niulechuan niulechuan deleted the fix-example-basic-pkg-name branch October 13, 2022 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants