Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marshalling multierror #3

Closed
malpiatko opened this issue Feb 28, 2016 · 3 comments
Closed

Marshalling multierror #3

malpiatko opened this issue Feb 28, 2016 · 3 comments

Comments

@malpiatko
Copy link

Hey,

I am using your multierror package in my project however I need to wrap it and add a MarshalJSON as it doesn't Marshal out of the box (because of the Func field). Would it be ok to add it to your project? In my case it would just marshal the error array. I don't know if you would want to do something more elaborate

@mitchellh
Copy link
Contributor

Sounds good to me. I commented on your PR, if we can unmarshal then I think its fine!

@malpiatko
Copy link
Author

I changed the code and answered your suggestions :)

@ConradIrwin
Copy link

@mitchellh Another attempt here: #15

The problem I was trying to solve was just that it fails, but adding a round-trip does seem kind of handy, so done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants