Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update go tools dependency #117

Merged
merged 1 commit into from Aug 17, 2022
Merged

build: update go tools dependency #117

merged 1 commit into from Aug 17, 2022

Conversation

pkazmierczak
Copy link

If run against code that uses generics, hclogvet will fail with an error:

hclogvet: Unexpected package creation during export data loading

which is due to it using an old version of go tools. This problem has recently been fixed, and building against newer go tools fixes the issue above.

Copy link
Member

@shoenig shoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; this should be fine since go1.17 and older is no longer supported.

@pkazmierczak pkazmierczak merged commit 1791bf6 into main Aug 17, 2022
@pkazmierczak pkazmierczak deleted the upgrade-go-tools branch August 17, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants