Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update dependencies #111

Merged
merged 1 commit into from May 16, 2022
Merged

build: update dependencies #111

merged 1 commit into from May 16, 2022

Conversation

shoenig
Copy link
Member

@shoenig shoenig commented May 12, 2022

This PR updates go.mod and hclogvet/go.mod (and sum files). This is necessary to pull in updates to make this library and tool compatible with the go1.18 compiler, which needs the newer stdlibs. Probably more info in golang/go#50558 but I didn't actually read all that.

[sah-d3ll nomad (updates)] $ go version 
go version go1.18.2 linux/amd64

before:

[nomad (main)] $ make check 
==> Linting source code...
==> Linting hclog statements...
hclogvet: internal error: package "bytes" without types was imported from "github.com/hashicorp/nomad"
make: *** [GNUmakefile:162: check] Error 1

after:

[nomad (updates)] $ make check
==> Linting source code...
==> Linting hclog statements...
==> Spell checking website...
(etc)

@shoenig shoenig requested review from evanphx and rboyer May 12, 2022 00:26
@shoenig shoenig merged commit af3b44c into main May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant