Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golang.org/x/sys to work with go1.18 #362

Merged
merged 1 commit into from May 19, 2022
Merged

Conversation

picatz
Copy link
Contributor

@picatz picatz commented May 19, 2022

This PR is a follow up to #360, to fix https://github.com/hashicorp/go-getter/runs/6498424476?check_suite_focus=true

...
   ⨯ release failed after 231.07s error=failed to build for darwin_amd64_v1: exit status 2: go: downloading github.com/cheggaaa/pb v1.0.27
...
golang.org/x/sys/unix
Error: /home/runner/go/pkg/mod/golang.org/x/sys@v0.0.0-20190624142023-c5567b49c5d0/unix/zsyscall_darwin_amd64.go:28:3: //go:linkname must refer to declared function or variable
Error: /home/runner/go/pkg/mod/golang.org/x/sys@v0.0.0-20190624142023-c5567b49c5d0/unix/zsyscall_darwin_amd64.go:43:3: //go:linkname must refer to declared function or variable
Error: /home/runner/go/pkg/mod/golang.org/x/sys@v0.0.0-20190624142023-c5567b49c5d0/unix/zsyscall_darwin_amd64.go:59:3: //go:linkname must refer to declared function or variable
Error: /home/runner/go/pkg/mod/golang.org/x/sys@v0.0.0-20190624142023-c5567b49c5d0/unix/zsyscall_darwin_amd64.go:75:3: //go:linkname must refer to declared function or variable
Error: /home/runner/go/pkg/mod/golang.org/x/sys@v0.0.0-20190624142023-c5567b49c5d0/unix/zsyscall_darwin_amd64.go:90:3: //go:linkname must refer to declared function or variable
Error: /home/runner/go/pkg/mod/golang.org/x/sys@v0.0.0-20190624142023-c5567b49c5d0/unix/zsyscall_darwin_amd64.go:105:3: //go:linkname must refer to declared function or variable
Error: /home/runner/go/pkg/mod/golang.org/x/sys@v0.0.0-20190624142023-c5567b49c5d0/unix/zsyscall_darwin_amd64.go:121:3: //go:linkname must refer to declared function or variable
Error: /home/runner/go/pkg/mod/golang.org/x/sys@v0.0.0-20190624142023-c5567b49c5d0/unix/zsyscall_darwin_amd64.go:136:3: //go:linkname must refer to declared function or variable
Error: /home/runner/go/pkg/mod/golang.org/x/sys@v0.0.0-201[90](https://github.com/hashicorp/go-getter/runs/6498424476?check_suite_focus=true#step:8:91)624142023-c5567b49c5d0/unix/zsyscall_darwin_amd64.go:151:3: //go:linkname must refer to declared function or variable
Error: /home/runner/go/pkg/mod/golang.org/x/sys@v0.0.0-20190624142023-c5567b49c5d0/unix/zsyscall_darwin_amd64.go:166:3: //go:linkname must refer to declared function or variable
Error: /home/runner/go/pkg/mod/golang.org/x/sys@v0.0.0-20190624142023-c5567b49c5d0/unix/zsyscall_darwin_amd64.go:166:3: too many errors

For more context, golang.org/x/sys/unix is an indirect dependency from github.com/cheggaaa/pb:

$ go mod why -m golang.org/x/sys
# golang.org/x/sys
github.com/hashicorp/go-getter/cmd/go-getter
github.com/cheggaaa/pb
golang.org/x/sys/unix

@picatz picatz requested review from eastebry and mdeggies May 19, 2022 13:49
@picatz picatz merged commit f710948 into main May 19, 2022
@picatz picatz deleted the update-x/sys-for-go1.18 branch May 19, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants