Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable ForceAttemptHTTP2 as default #17

Closed
kodawah opened this issue Jan 26, 2021 · 1 comment
Closed

Enable ForceAttemptHTTP2 as default #17

kodawah opened this issue Jan 26, 2021 · 1 comment

Comments

@kodawah
Copy link

kodawah commented Jan 26, 2021

Hi,
I'm using cleanhttp through retryablehttp, and one of the site I'm querying is making me upgrade to HTTP2.
However the default implementation of cleanhttp does not let the connection happen, and makes the request return empty data.
I tried to debug this a bit, and it seems that ForceAttemptHTTP2 is missing from the default options, and by manually setting it to true, the connection happens and data is returned correctly.
This flag has been added to the http.DefaultTransport, would it be possible to enable for the default transport options in this package too?
Thanks
@jefferai
Copy link
Member

jefferai commented Feb 3, 2021

I've added this! Will cut a new release now.

@jefferai jefferai closed this as completed Feb 3, 2021
This was referenced Mar 11, 2021
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jefferai @kodawah