WithUnknownValue to treat unknown values as a non-error #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces a new option "WithUnknownValue" that can be used to specify some value to use for unknown keys. Normally, bexpr will error (and this continues to be the default). However, an alternate zero value behavior can be specified to use that instead. This is useful for situations where you want to treat empty values as say... empty string so that an expression generally fails but with a false rather than an error. This also updates to pointerstructure 1.2.1 which fixes on "not found" case that wasn't wrapping ErrNotFound properly.
mitchellh
force-pushed
the
feature/unknownval
branch
from
8e71c43
to
46883af
Compare
jefferai
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new option "WithUnknownValue" that can be used to
specify some value to use for unknown keys. Normally, bexpr will error
(and this continues to be the default). However, an alternate zero value
behavior can be specified to use that instead.
This is useful for situations where you want to treat empty values as
say... empty string so that an expression generally fails but with a
false rather than an error.
This also updates to pointerstructure 1.2.1 which fixes on "not found"
case that wasn't wrapping ErrNotFound properly.