ui: Remove old style 'filterable' searching #9356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxcode
approved these changes
Dec 9, 2020
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/294734. |
|
🍒✅ Cherry pick of commit 2c3b6ae onto |
hashicorp-ci
pushed a commit
that referenced
this pull request
Dec 9, 2020
* Switch upstream-instances to use new style of searchable * Add search action to DataCollection plus basic README * Use DataCollection for PowerSelect searching in child-selectors * Remove old style filterable search for role/policies and instances * Remove old helpers/components related to search/sort/filter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our old style searching was based on an asynchronous based component (ChangeableSet) where you would pass a 'filterable/searchable' to it and it would use that filterable/searchable to perform the searching. This has now been entirely replaced with
DataCollectioncomponent that follows a similar approach but can perform all types of 'Collection' type tasks on a collection/array of data - so searching, filtering and sorting.The final things to be replaced were searching/filtering/sorting of
upstream-instancesand also searching/sorting of our 'ChildSelector' component which is used for selecting Roles and Policies whilst creating tokens and namespaces, which we switch out here.There is still a tiny bit of work to go on the
DataCollectioncomponent, but I started adding a README file here for it in order to document out its properties a little, and I'll probably fill it out a little more once its complete.