Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Update UI README #9346

Merged
merged 7 commits into from
Dec 9, 2020
Merged

ui: Update UI README #9346

merged 7 commits into from
Dec 9, 2020

Conversation

johncowen
Copy link
Contributor

Following on from boundary-uis style, we've updated our UI readme here to include various yarn commands and some more documentation on our environment-like cookie variables.

In trying to stick close to what boundary are doing, we added npm-run-all also here for running multiple scripts of the same type, and we'll probably update our make file at some point to make better use of this.

@johncowen johncowen added theme/ui Anything related to the UI backport/1.9 labels Dec 8, 2020
Copy link
Contributor

@kaxcode kaxcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 This looks great!

@johncowen johncowen merged commit d6cb2b0 into master Dec 9, 2020
@johncowen johncowen deleted the ui/chore/update-ui-readme branch December 9, 2020 18:41
@hashicorp-ci
Copy link
Contributor

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/294579.

@hashicorp-ci
Copy link
Contributor

🍒✅ Cherry pick of commit d6cb2b0 onto release/1.9.x succeeded!

hashicorp-ci pushed a commit that referenced this pull request Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/ui Anything related to the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants