local: mark service as InSync when added to local agent state #9284
Conversation
There was a problem hiding this comment.
This looks great Daniel. I could be wrong but I think we need to also add the IsSame check for Checks that are part of the registration.
I think this would be easy to confirm by adding a service-level check to the registration in the test - I think if you do that you'll see it fail again as the check would still be marked as InSync = false even when it hasn't changed so will cause an extra RPC.
dnephin
force-pushed
the
dnephin/agent-service-register
branch
from
1b2829c
to
3b3e907
Compare
If the existing service and checks are the same as the new registration.
dnephin
force-pushed
the
dnephin/agent-service-register
branch
from
3b3e907
to
33b8106
Compare
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/289221. |
|
🍒✅ Cherry pick of commit 9f0f2bd onto |
local: mark service as InSync when added to local agent state
|
Do we want to manually backport this to 1.8 and 1.7? |
|
This was a relatively minor problem that we only discovered when testing at a large scale, and even then it wasn't really breaking anything it was just surprising. So I think we shouldn't spend the time to manually backport unless it becomes a problem for someone. |
When the existing service is the same as the new service.
Fixes #9266