Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inability to remember metrics #9208

Open
nahratzah opened this issue Nov 17, 2020 · 1 comment
Open

inability to remember metrics #9208

nahratzah opened this issue Nov 17, 2020 · 1 comment
Labels
theme/telemetry Anything related to telemetry or observability

Comments

@nahratzah
Copy link

Overview of the Issue

Issue #5140 was closed, on the basis that #9198 addresses it.

Except, the issue #5140 mentions two problems:

  1. Only changed metrics are initialized on Consul start
    (Which is addressed by Add metric definitions for all metrics known at Consul start #9198)
  2. After prometheus_retention_time expires they also get removed
    (Which is not addressed.)

The change #9198 will initialize metrics at startup, only to forget them once prometheus_retention_time expires.

@dnephin dnephin added the theme/telemetry Anything related to telemetry or observability label Nov 17, 2020
@dnephin
Copy link
Contributor

dnephin commented Nov 17, 2020

The second problem should be fixed by hashicorp/go-metrics#120, which was included in Consul in 9d9c4a6.

Are you able to reproduce the problem with those changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/telemetry Anything related to telemetry or observability
Projects
None yet
Development

No branches or pull requests

2 participants