Refactor to call non-voting servers read replicas #9191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
theme/api
mkeeler
force-pushed
the
refactor/read-replicas
branch
from
12aef88
to
ad12d29
Compare
mkeeler
force-pushed
the
refactor/read-replicas
branch
from
ad12d29
to
861adee
Compare
mkeeler
commented
Nov 13, 2020
mkeeler
force-pushed
the
refactor/read-replicas
branch
from
861adee
to
cb26476
Compare
mkeeler
force-pushed
the
refactor/read-replicas
branch
from
cb26476
to
4d777f3
Compare
mkeeler
force-pushed
the
refactor/read-replicas
branch
2 times, most recently
from
eebc9be
to
51f40b7
Compare
This hopefully will prevent some confusion and also make it clearer that redundancy zones don’t rely on non voting servers.
Co-authored-by: Kit Patella <kit@jepsen.io>
mkeeler
force-pushed
the
refactor/read-replicas
branch
from
51f40b7
to
3e6c17c
Compare
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/283524. |
|
🍒✅ Cherry pick of commit 66fd23d onto |
hashicorp-ci
pushed a commit
that referenced
this pull request
Nov 17, 2020
Co-authored-by: Kit Patella <kit@jepsen.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hopefully will prevent some confusion and also make it clearer that redundancy zones don’t rely on non voting servers.
Most of this is a simple refactoring of variable names and changing docs. There are a number of deprecations of old names in favor of the new naming. In all cases (serf tags, cli flags, configuration settings, and
consulservice meta) both the old and new names will coexist together and the deprecation notices say that the old names will be removed in a future release.