Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to using the external autopilot module #9103

Merged
merged 2 commits into from
Nov 9, 2020
Merged

Switch to using the external autopilot module #9103

merged 2 commits into from
Nov 9, 2020

Conversation

mkeeler
Copy link
Member

@mkeeler mkeeler commented Nov 4, 2020 •
edited

This replaces the builtin agent/consul/autopilot package with the code that now lives in github.com/hashicorp/raft-autpilot. For OSS Consul not much has changed behaviorally except that some more information about things can be retrieved from the v1/operator/autopilot/state endpoint.

Note that before this can be merged we need to merge this pr into the new raft-autopilot repo, tag a release and fixup the go.mod to use that version.

Follow on work:

  • Documentation updates
  • Add CLI for retrieving the autopilot state and displaying it.
  • Add API function for retrieving the autopilot state (the types already exist)

@github-actions github-actions bot added pr/dependencies PR specifically updates dependencies of project theme/api Relating to the HTTP API interface theme/cli Flags and documentation for the CLI interface labels Nov 4, 2020
@mkeeler mkeeler added this to the 1.9.0-beta2 milestone Nov 4, 2020
@mkeeler mkeeler requested a review from a team November 4, 2020 21:32
@mkeeler mkeeler force-pushed the feature/autopilot-mod branch 4 times, most recently from be549d4 to e73b3c2 Compare November 5, 2020 18:13
@mkeeler mkeeler force-pushed the feature/autopilot-mod branch 2 times, most recently from 2637b76 to dd82d46 Compare November 5, 2020 20:16
crhino
crhino reviewed Nov 6, 2020
View reviewed changes
api/operator_autopilot.go Outdated Show resolved Hide resolved
@mkeeler mkeeler modified the milestones: 1.9.0-beta2, 1.9.0 Nov 6, 2020
mkeeler
mkeeler commented Nov 6, 2020
View reviewed changes
agent/consul/autopilot_test.go Show resolved Hide resolved
agent/consul/server.go Show resolved Hide resolved
agent/consul/server_oss.go Show resolved Hide resolved
crhino
crhino approved these changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@crhino crhino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mkeeler mkeeler merged commit 8d4334c into master Nov 9, 2020
@mkeeler mkeeler deleted the feature/autopilot-mod branch November 9, 2020 16:30
@hashicorp-ci
Copy link
Contributor

🍒✅ Cherry pick of commit 8d4334c onto release/1.9.x succeeded!

hashicorp-ci pushed a commit that referenced this pull request Nov 9, 2020
@mkeeler @hashicorp-ci
Merge pull request #9103 from hashicorp/feature/autopilot-mod
8539565 
Switch to using the external autopilot module
@mikemorris mikemorris mentioned this pull request Aug 27, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crhino crhino crhino approved these changes

Assignees
No one assigned
Labels
pr/dependencies PR specifically updates dependencies of project theme/api Relating to the HTTP API interface theme/cli Flags and documentation for the CLI interface
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mkeeler @hashicorp-ci @crhino @hashibot-web