Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for envoy readiness flags #16015

Merged
merged 2 commits into from
Jan 19, 2023
Merged

Conversation

thisisnotashwin
Copy link
Contributor

@thisisnotashwin thisisnotashwin commented Jan 19, 2023

  • add flags envoy-ready-bind-port and envoy-ready-bind-addr on consul connect envoy to create a ready listener on that address.

@thisisnotashwin thisisnotashwin added backport-inactive/1.13 This release series is no longer active backport-inactive/1.14 This release series is no longer active labels Jan 19, 2023
@thisisnotashwin thisisnotashwin requested a review from a team as a code owner January 19, 2023 21:26
@github-actions github-actions bot added theme/cli Flags and documentation for the CLI interface type/docs Documentation needs to be created/updated/clarified labels Jan 19, 2023
- add flags 'envoy-ready-bind-port` and `envoy-ready-bind-addr` on
  consul connect envoy to create a ready listener on that address.
Copy link
Member

@DanStough DanStough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We'll have to delete the changelog entry on the ENT side, so it doesn't show up twice next week.

.changelog/16015.txt Show resolved Hide resolved
Copy link
Member

@DanStough DanStough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NM, I think we're missing the goldenfile here.

Copy link
Member

@DanStough DanStough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@thisisnotashwin thisisnotashwin merged commit a1e2a4f into main Jan 19, 2023
@thisisnotashwin thisisnotashwin deleted the ashwin/envoy-readiness branch January 19, 2023 21:54
thisisnotashwin added a commit that referenced this pull request Jan 19, 2023
* Add support for envoy readiness flags
- add flags 'envoy-ready-bind-port` and `envoy-ready-bind-addr` on consul connect envoy to create a ready listener on that address.
thisisnotashwin added a commit that referenced this pull request Jan 19, 2023
* Add support for envoy readiness flags
- add flags 'envoy-ready-bind-port` and `envoy-ready-bind-addr` on consul connect envoy to create a ready listener on that address.
thisisnotashwin added a commit that referenced this pull request Jan 19, 2023
* Add support for envoy readiness flags
- add flags 'envoy-ready-bind-port` and `envoy-ready-bind-addr` on consul connect envoy to create a ready listener on that address.
thisisnotashwin added a commit that referenced this pull request Jan 19, 2023
* Add support for envoy readiness flags
- add flags 'envoy-ready-bind-port` and `envoy-ready-bind-addr` on consul connect envoy to create a ready listener on that address.
sarahalsmiller pushed a commit that referenced this pull request Jan 20, 2023
* Add support for envoy readiness flags
- add flags 'envoy-ready-bind-port` and `envoy-ready-bind-addr` on consul connect envoy to create a ready listener on that address.
skpratt pushed a commit that referenced this pull request Jan 25, 2023
* Add support for envoy readiness flags
- add flags 'envoy-ready-bind-port` and `envoy-ready-bind-addr` on consul connect envoy to create a ready listener on that address.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-inactive/1.13 This release series is no longer active backport-inactive/1.14 This release series is no longer active theme/cli Flags and documentation for the CLI interface type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants