Fix issue with incorrect proxycfg watch on upstream peer-targets. #15865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where the incorrect partition was given to the upstream target watch, which meant that failover logic would not work correctly.
hashi-derek
force-pushed
the
derekm/NET-1892/failovers
branch
from
41a3cc9
to
699d4b0
Compare
hashi-derek
added
the
backport-inactive/1.14
ndhanushkodi
approved these changes
Dec 22, 2022
| // | ||
| // Note that the namespace is not swapped out, because it should | ||
| // always match the value in the remote datacenter (and shouldn't | ||
| // have been changed anywhere). |
There was a problem hiding this comment.
Thank you for this comment, so helpful!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes when envoy was configured to do failovers to peered clusters, the SNI / SAN information was missing from the xDS configuration, which means that it was impossible to connect to the mesh gateway correctly.
This issue occurs because the incorrect partition / datacenter was used when creating watches from upstream targets. The datacenter / partition from discovery-chain peer-targets should NOT be used to perform lookups, since the fields are intentionally cleared during compilation (disco chain target fields indicate the destination's data, not the source's data).
Instead, the local datacenter / partition should be provided to the query so that it can properly lookup services.