Fix incorrect protocol check on discovery chains with peer targets. #15833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rboyer
reviewed
Dec 19, 2022
| // TODO: Add in remote peer protocol validation when building a chain. | ||
| // This likely would require querying the imported services, which | ||
| // shouldn't belong in the discovery chain compilation here. | ||
| if target.Peer == "" { |
There was a problem hiding this comment.
Ah so this boils down to "there is not a service-defaults for imported services to store the protocol" if I'm understanding.
There was a problem hiding this comment.
Yup. I was still writing the description up for the ticket, haha. I guess the system automatically assigned you to this PR.
hashi-derek
force-pushed
the
derekm/NET-1891/protocol-mismatch
branch
from
d73cb02
to
5984ad3
Compare
hashi-derek
force-pushed
the
derekm/NET-1891/protocol-mismatch
branch
from
5984ad3
to
36891f3
Compare
hashi-derek
added
the
backport-inactive/1.14
erichaberkorn
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following message is incorrectly printed out whenever saving a service-resolver with a peer failover target.
discovery chain "my-chain" uses inconsistent protocols; service "my-service" has "tcp" which is not "http"This PR excludes peer targets from the protocol validation logic when building discovery chains, which should prevent the error from occurring.
Steps to reproduce:
Be careful to ensure that no "myremote" service-default exists in the local cluster, as it will actually be looked up, and the error will not surface.