xds: don't attempt to load-balance sessions for local proxies #15789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boxofrad
added
the
backport-inactive/1.14
github-actions
bot
added
theme/agent-cache
boxofrad
force-pushed
the
boxofrad/bugfix-server-local-limit
branch
from
e1f73a3
to
5ce183d
Compare
rboyer
reviewed
Dec 14, 2022
boxofrad
force-pushed
the
boxofrad/bugfix-server-local-limit
branch
from
2527368
to
d66663f
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
boxofrad
force-pushed
the
boxofrad/bugfix-server-local-limit
branch
from
5240ae7
to
8679e2c
Compare
Previously, we'd begin a session with the xDS concurrency limiter regardless of whether the proxy was registered in the catalog or in the server's local agent state. This caused problems for users who run `consul connect envoy` directly against a server rather than a client agent, as the server's locally registered proxies wouldn't be included in the limiter's capacity. Now, the `ConfigSource` is responsible for beginning the session and we only do so for services in the catalog. Fixes: #15753
boxofrad
force-pushed
the
boxofrad/bugfix-server-local-limit
branch
from
8679e2c
to
d19960c
Compare
|
Hey @rboyer 👋🏻 I've fixed CI and the missing |
rboyer
approved these changes
Jan 18, 2023
boxofrad
added a commit
that referenced
this pull request
Jan 18, 2023
Previously, we'd begin a session with the xDS concurrency limiter regardless of whether the proxy was registered in the catalog or in the server's local agent state. This caused problems for users who run `consul connect envoy` directly against a server rather than a client agent, as the server's locally registered proxies wouldn't be included in the limiter's capacity. Now, the `ConfigSource` is responsible for beginning the session and we only do so for services in the catalog. Fixes: #15753
boxofrad
added a commit
that referenced
this pull request
Jan 19, 2023
#16004) Previously, we'd begin a session with the xDS concurrency limiter regardless of whether the proxy was registered in the catalog or in the server's local agent state. This caused problems for users who run `consul connect envoy` directly against a server rather than a client agent, as the server's locally registered proxies wouldn't be included in the limiter's capacity. Now, the `ConfigSource` is responsible for beginning the session and we only do so for services in the catalog. Fixes: #15753 Co-authored-by: Dan Upton <daniel@floppy.co>
skpratt
pushed a commit
that referenced
this pull request
Jan 25, 2023
Previously, we'd begin a session with the xDS concurrency limiter regardless of whether the proxy was registered in the catalog or in the server's local agent state. This caused problems for users who run `consul connect envoy` directly against a server rather than a client agent, as the server's locally registered proxies wouldn't be included in the limiter's capacity. Now, the `ConfigSource` is responsible for beginning the session and we only do so for services in the catalog. Fixes: #15753
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, we'd begin a session with the xDS concurrency limiter regardless of whether the proxy was registered in the catalog or in the server's local agent state.
This caused problems for users who run
consul connect envoydirectly against a server rather than a client agent, as the server's locally registered proxies wouldn't be included in the limiter's capacity.Now, the
ConfigSourceis responsible for beginning the session and we only do so for services in the catalog (bypassing the limiter for locally-registered proxies).Fixes: #15753
Also upgrades mockery to v2.15.0, as this was required to regenerate the mocks on Go 1.19.
Testing & Reproduction steps
consul connect envoyfor each proxy.