agent: Fix assignment of error when auto-reloading cert and key file changes. #15769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
jmurret
changed the title
jmurret
changed the title
dhiaayachi
approved these changes
Dec 12, 2022
There was a problem hiding this comment.
Thank you for extracting this @jmurret, LGTM!
Do you think we should backport this to 1.14,1.13 and 1.12? I think it's self contained enough to be considered.
|
@dhiaayachi Agree. Will backport. |
jmurret
added
backport-inactive/1.12
This was referenced Dec 12, 2022
t-eckert
pushed a commit
that referenced
this pull request
Dec 15, 2022
…changes. (#15769) * Adding the setting of errors missing in config file watcher code in agent. * add changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For both the key and cert file watcher code, a call to
a.configFileWatcher.Replace()is made but the error returned from this called is not used...but a check is right below it like this:This seems to be an omission rather than strategic. In its current case, this will either check on a previous error, or will never get triggered because a previous check would have exited.
PR Checklist