Enforce lowercase peer names. #15697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashi-derek
force-pushed
the
derekm/NET-1737/lowercase-peername
branch
from
8e8e5ec
to
50ceec9
Compare
Prior to this change peer names could be mixed case. This can cause issues, as peer names are used as DNS labels in various locations. It also caused issues with envoy configuration.
hashi-derek
force-pushed
the
derekm/NET-1737/lowercase-peername
branch
from
50ceec9
to
e188932
Compare
hashi-derek
added
the
backport-inactive/1.14
hashi-derek
requested review from
a team,
kyhavlov and
ndhanushkodi
and removed request for
a team
hashi-derek
removed
the
backport-inactive/1.14
ndhanushkodi
approved these changes
Jan 13, 2023
hashi-derek
added
the
backport-inactive/1.14
skpratt
pushed a commit
that referenced
this pull request
Jan 25, 2023
Enforce lowercase peer names. Prior to this change peer names could be mixed case. This can cause issues, as peer names are used as DNS labels in various locations. It also caused issues with envoy configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change peer names could be mixed case. This can cause issues, as many state store lookups and some envoy configurations are case-sensitive, but TLS certificates and DNS are not.
This PR does not modify existing peering connections. It only prevents new ones from being created that include uppercase characters. Users are encouraged to delete old peerings and recreate them with all lowercase characters.