Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(peering): remove beta references #15340

Merged
merged 5 commits into from Nov 14, 2022

Conversation

DanStough
Copy link
Member

Description

Cluster peering will be GA for the Consul 1.14 release. This PR removes the beta references from the site.

There will be subsequent PRs to handle other content updates, namely:

  1. Control Plane usage
  2. Mesh gateway control
  3. Changes to ACL permissions

@DanStough DanStough added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-metrics-test backport/1.14 Changes are backported to 1.14 labels Nov 11, 2022
@DanStough DanStough requested a review from a team November 11, 2022 18:00
@DanStough DanStough requested a review from a team as a code owner November 11, 2022 18:00
@github-actions github-actions bot added the type/docs Documentation needs to be created/updated/clarified label Nov 11, 2022
@hc-github-team-consul-core
Copy link
Contributor

All unit tests passed! Your changes bring test coverage over affected code to 48.4%. Total coverage in main is 63.8%. See coverage delta for your changes

Copy link
Contributor

@erichaberkorn erichaberkorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to remove .github/go_test_coverage.txt?

website/content/docs/connect/cluster-peering/index.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@erichaberkorn erichaberkorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the test coverage file is a bot. This looks good to me 👍

Copy link
Contributor

@boruszak boruszak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some minor suggestions to improve the language/clarity - otherwise LGTM!

Thanks for making these changes! Approving on behalf of consul-docs.

DanStough and others added 2 commits November 14, 2022 11:25
Co-authored-by: Jeff Boruszak <104028618+boruszak@users.noreply.github.com>
@DanStough DanStough merged commit e426b79 into main Nov 14, 2022
@DanStough DanStough deleted the dans/NET-640/peering-docs-remove-beta branch November 14, 2022 19:49
DanStough added a commit that referenced this pull request Nov 14, 2022
* docs(peering): remove beta references
DanStough added a commit that referenced this pull request Nov 14, 2022
* docs(peering): remove beta references
DanStough added a commit that referenced this pull request Nov 14, 2022
* docs(peering): remove beta references

Co-authored-by: Dan Stough <dan.stough@hashicorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.14 Changes are backported to 1.14 pr/no-changelog PR does not need a corresponding .changelog entry pr/no-metrics-test type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants