Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Exported Service List Event to Cluster Peering Replication #14797

Merged
merged 1 commit into from Sep 29, 2022

Conversation

erichaberkorn
Copy link
Contributor

Description

  • The exported service list event is used to ensure un-exported services get deleted even if the un-export happens while cluster peering replication is down.

Event Changes

Action Before After Change in replicated event count
Remove all service instances of an exported service One TypeURLExportedService delete event. One TypeURLExportedService upsert event. 0
Unexport services TypeURLExportedService upsert events for services with IndexedCheckServiceNodes. TypeURLExportedService delete events for services without IndexedCheckServiceNodes and unexported services. One TypeURLExportedServiceList event. TypeURLExportedService upsert events for each exported service. No TypeURLExportedService events for unexported services. A decrease by the number of unexported services minus one.
Export services TypeURLExportedService upsert events for services with IndexedCheckServiceNodes. TypeURLExportedService delete events for services without IndexedCheckServiceNodes. One TypeURLExportedServiceList event. TypeURLExportedService upsert events for each exported service. One additional event.

PR Checklist

  • updated test coverage
  • external facing docs updated - NA
  • not a security concern

Copy link
Contributor

@freddygv freddygv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@erichaberkorn erichaberkorn merged commit 80e51ff into main Sep 29, 2022
@erichaberkorn erichaberkorn deleted the unexport-services branch September 29, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants