Fix peering establishment bugs on followers #14119
Merged
+81
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kisunji
added
backport/1.13
theme/cluster-peering
freddygv
reviewed
Aug 10, 2022
| @@ -816,6 +816,7 @@ func newGRPCHandlerFromConfig(deps Deps, config *Config, s *Server) connHandler | |||
|
|
|||
| // Note: these external gRPC services are also exposed on the internal server to | |||
| // enable RPC forwarding. | |||
| s.peerStreamServer.Register(srv) | |||
There was a problem hiding this comment.
Can you add a test to ensure that forwarding is working? Here's an example:
https://github.com/hashicorp/consul-enterprise/blob/main/agent/consul/partition_backend_test.go#L84
If you comment out this change the unknown service error should come up
There was a problem hiding this comment.
Confirmed unknown service comes up without this change
| @@ -1332,3 +1333,13 @@ func TestLeader_Peering_retryLoopBackoffPeering_cancelContext(t *testing.T) { | |||
| fmt.Errorf("error 1"), | |||
| }, allErrors) | |||
| } | |||
|
|
|||
| func Test_isFailedPreconditionErr(t *testing.T) { | |||
kisunji
changed the title
freddygv
approved these changes
Aug 10, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
isFailedPreconditionErrdid not properly handle wrapped status errorsrpc error: code = Unimplemented desc = unknown service hashicorp.consul.internal.peerstream.PeerStreamServiceTesting & Reproduction steps
PR Checklist