Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

development docs #26

Merged
merged 5 commits into from Jan 11, 2023
Merged

development docs #26

merged 5 commits into from Jan 11, 2023

Conversation

samsalisbury
Copy link
Contributor

Updating README and documenting dev workflow.

docs/development.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@shore shore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments. Thank you for documenting this, Sam!

docs/development.md Show resolved Hide resolved
docs/development.md Outdated Show resolved Hide resolved
@samsalisbury
Copy link
Contributor Author

Thanks for the reviews @alvin-huang and @shore! I've added the missing details, and also documented the git pre-push hook. I also turned off one of the pre-push hook's checks (that the branch has the latest development version set) because it's probably not necessary.

Copy link
Contributor

@shore shore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@samsalisbury samsalisbury merged commit 75a9f70 into main Jan 11, 2023
@samsalisbury samsalisbury deleted the docs branch January 11, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants