Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SemanticVersion class to have hashcode function #760

Open
leninmehedy opened this issue Feb 15, 2024 · 0 comments
Open

Update SemanticVersion class to have hashcode function #760

leninmehedy opened this issue Feb 15, 2024 · 0 comments
Assignees
@leninmehedy
Labels
Bug A error that causes the feature to behave differently than what was expected based on design docs

Comments

@leninmehedy
Copy link
Member

leninmehedy commented Feb 15, 2024 •
edited

According to "Effective Java - Joshua Bloch", Chapter -3 (Item 11): Always override hashCode when you override equals,

This is because, otherwise it would cause issues when using these objects in HashMap and HashSet

https://github.com/hashgraph/full-stack-testing/blob/main/fullstack-core/fullstack-base-api/src/main/java/com/hedera/fullstack/base/api/version/SemanticVersion.java#L145

Also we need to add relavent unit tests
@leninmehedy leninmehedy self-assigned this Feb 15, 2024
@leninmehedy leninmehedy added the Bug A error that causes the feature to behave differently than what was expected based on design docs label Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leninmehedy leninmehedy

Labels
Bug A error that causes the feature to behave differently than what was expected based on design docs
Projects
FST Suite
Status: 🆕 New
Milestone
No milestone
Development

No branches or pull requests
1 participant
@leninmehedy