Custom tag registration doesn't work in Liquid v10

[oscarotero]

Hi.
In Liquidjs v9 I have the following code to create custom tags:

engine.registerTag('upper', {
  parse: function(tagToken, remainTokens) {
      this.str = tagToken.args;
  },
  render: async function(ctx) {
      const str = await this.liquid.evalValue(this.str, ctx);
      return str.toUpperCase();
  }
});

This code fails in Liquid 10: Uncaught RenderError: Cannot read properties of undefined (reading 'toUpperCase').

I found this example in the documentation but it doesn't work either:

engine.registerTag('upper', {
    parse: function(tagToken) {
        this.str = tagToken.args; // name
    },
    render: function*(ctx) {
        const str = yield this.liquid.evalValue(this.str, ctx);
        return str.toUpperCase()
    }
});

[harttle]

I didn't realize evalValue is advocated in docs and demos. I removed support for Context as second parameter when dealing with #527 because it's not used my source code. Now added it back because I think it's indeed convenient (so I used it in my docs).

Performance-wise, it's better to create new Value() during parse, and call value.value() in render(). As in the implementation of builtin tags.

[oscarotero]

Thanks for the fast response.

Performance-wise, it's better to create new Value() during parse, and call value.value() in render(). As in the implementation of builtin tags.

I don't have any preference, so if it's more perfomant this suggestion, I'll change it. Can you provide an example for that (or update the example in the documentation)? Somethig like this:

engine.registerTag('upper', {
  parse: function(tagToken, remainTokens) {
      this.val = new Value(tagToken.args);
  },
  render: async function(ctx) {
      const str = this.val.value();
      return str.toUpperCase();
  }
});

[github-actions]

🎉 This issue has been resolved in version 10.3.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[harttle]

Updated this tutorial: https://liquidjs.com/tutorials/sync-and-async.html as well. Hope it helps!

[oscarotero]

Perfect. Thanks!