Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

truncatewords should default use at least one word #537

Closed
sebastienros opened this issue Sep 21, 2022 · 1 comment
Closed

truncatewords should default use at least one word #537

sebastienros opened this issue Sep 21, 2022 · 1 comment
Labels
bug

Comments

@sebastienros
Copy link

Test case:
https://liquidjs.com/playground.html#e3sgIm9uZSB0d28gdGhyZWUiIHwgdHJ1bmNhdGV3b3JkczowIH19,e30=

{{ "one two three" | truncatewords:0 }} should return "one..."

Source:
https://github.com/Shopify/liquid/blob/81f44e36be5f2110c26b6532fd4ccd22edaf59f2/lib/liquid/standardfilters.rb#L237

https://github.com/Shopify/liquid/blob/ff1c35b986451cca14d9da9b2ef772cbc9c65b24/test/integration/standard_filter_test.rb#L229
@sebastienros
Copy link
Author

sebastienros commented Sep 21, 2022 •
edited

I also believe that " one two three" should strip the first spaces in the results. You are adding a single space right now.

@harttle harttle added the bug label Sep 25, 2022
harttle added a commit that referenced this issue Oct 21, 2022
@harttle
fix: truncatewords should use at least one word, #537
32f613f
github-actions bot pushed a commit that referenced this issue Oct 21, 2022
@semantic-release-bot
chore(release): 9.42.1 [skip ci]
bf6b5c7 
## [9.42.1](v9.42.0...v9.42.1) (2022-10-21)

### Bug Fixes

* truncatewords should use at least one word, [#537](#537) ([32f613f](32f613f))
@harttle harttle closed this as completed Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sebastienros @harttle