From 8c0dbade6b45a6a528a271a4cf0f088cec0a052c Mon Sep 17 00:00:00 2001 From: Harsh Kukreja Date: Sun, 22 Mar 2020 18:57:29 +0530 Subject: [PATCH] Issue #7855: Resolve Pitest Issues - IllegalImportCheck (2) --- .ci/pitest.sh | 1 - .../tools/checkstyle/checks/imports/IllegalImportCheck.java | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.ci/pitest.sh b/.ci/pitest.sh index 6632c1d5c96..1ef1c66f490 100755 --- a/.ci/pitest.sh +++ b/.ci/pitest.sh @@ -72,7 +72,6 @@ pitest-imports) mvn -e -P$1 clean test org.pitest:pitest-maven:mutationCoverage; declare -a ignoredItems=( "CustomImportOrderCheck.java.html:
        if (bestMatch.group.equals(NON_GROUP_RULE_GROUP)) {
" - "IllegalImportCheck.java.html:
        if (!result && illegalClasses != null) {
" "IllegalImportCheck.java.html:
        if (!result) {
" "ImportControlLoader.java.html:
        else if (ALLOW_ELEMENT_NAME.equals(qName) || "disallow".equals(qName)) {
" "ImportOrderCheck.java.html:
                else if (matcher.start() == bestPos && matcher.end() > bestEnd) {
" diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/imports/IllegalImportCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/imports/IllegalImportCheck.java index a2d2be6fc69..c7a56dde1d6 100644 --- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/imports/IllegalImportCheck.java +++ b/src/main/java/com/puppycrawl/tools/checkstyle/checks/imports/IllegalImportCheck.java @@ -419,7 +419,7 @@ private boolean isIllegalImportByPackagesAndClassNames(String importText) { break; } } - if (!result && illegalClasses != null) { + if (illegalClasses != null) { for (String element : illegalClasses) { if (importText.equals(element)) { result = true;