Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement std::error::Error when not using failure #16

Merged
merged 1 commit into from
Sep 27, 2019

Conversation

faern
Copy link
Contributor

@faern faern commented Sep 23, 2019

I'm personally not a fan of using failure in libraries. Since it breaks the ecosystem into those who expose Fail errors and those who expose std::error::Error errors. Now when failure is optional here, it was very easy to add support for making the which error type a standard error.

@faern
Copy link
Contributor Author

faern commented Sep 23, 2019

This makes it easier for libraries based on top of which that want to in turn expose an Error type implementing std::error::Error. Because now they (we) don't have to wrap this in failure::Compat<which::Error> in order to achieve that.

@harryfei
Copy link
Owner

Nice. Thanks.

@harryfei harryfei merged commit b0c86e6 into harryfei:master Sep 27, 2019
@harryfei
Copy link
Owner

harryfei commented Nov 4, 2019

Released 3.1.0 in crates.io.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants