fix(expression) handle canonical time zone designations correctly #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From the CI, it looks like the new system test fails for Node 12 only (passing for Node 14, 15, 16, and 17). The failure for Node 12 is the same before and after the other changes in this PR, which I think shows that this PR fixes this issue for Node versions 14 and newer and makes it no worse for Node version 12. |
DonBrinn
commented
Jun 27, 2022
DonBrinn
commented
Jun 27, 2022
test/expression.js
Outdated
Comment on lines
1238
to
1254
| test('it will work with #271 issue case for Node v > 12', function(t) { | ||
| if(process.versions.node.startsWith('12.')) { | ||
| t.end(); | ||
| return; | ||
| } | ||
| var options = { | ||
| currentDate : new Date('2022-01-01T00:00:00.000Z'), | ||
| tz: 'EST5EDT' | ||
| }; | ||
|
|
||
| var interval = CronExpression.parse('0 0 5 * * *', options); | ||
| var date = interval.next(); | ||
|
|
||
| t.equal(date.toISOString(), '2022-01-01T10:00:00.000Z'); | ||
|
|
||
| t.end(); | ||
| }); |
There was a problem hiding this comment.
If you would prefer that we bump to Luxon v 2 but do not add this test case, please let me know and I can remove this new test.
There was a problem hiding this comment.
@DonBrinn yes, let's remove it and just proceed with package version bump.
DonBrinn
commented
Jun 27, 2022
harrisiirak
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #271.
The new unit test was added first, as test-driven development. The new unit test failed with the following error before package.json was updated.
After package.json was updated to use the newer version of Luxon, the new unit test succeeded.
The results of all other tests were unchaged by using the new version of Luxon.