Support "last weekday of the month" expressions #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@harrisiirak Can you spare some time to review this PR? 🙏 We need this functionality fairly soon, and I would like to avoid the need to release a fork |
|
@albertorestifo sure, I'll try go through the PR during this weekend. Sorry about the delay! |
harrisiirak
reviewed
Oct 9, 2021
There was a problem hiding this comment.
@albertorestifo thanks for your hard work, this looks very good and promising!
My main concerns and questions are:
- It has support of multiple multiple expressions, which could be definitely useful, but it's non-standard feature and possibly adds some unexpected behaviour; see my longer comment in PR, we can discuss it further over there.
- It would be also nice to have serialization/stringify support (see this example for last day of month) for this feature
- Some code style issues (nitpicking, I know, existing code in this repo could need some cleanup + better linting rules); added some comments and suggestions
Co-authored-by: Harri Siirak <harri@siirak.ee>
|
@harrisiirak thanks for taking the time to review the PR. I've addressed all your comments, as well as written some documentation for the newly added feature. |
harrisiirak
reviewed
Oct 11, 2021
harrisiirak
approved these changes
Oct 12, 2021
|
Closes #242 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements support for the expressions like "last Monday of the month" (
0 0 0 * * 1L) by adding support for\dLin the weekday part of the cron expression.