Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export moment or moment API #171

Closed
ghost opened this issue Sep 20, 2019 · 2 comments
Closed

Export moment or moment API #171

ghost opened this issue Sep 20, 2019 · 2 comments

Comments

@ghost
Copy link

ghost commented Sep 20, 2019

Do you think is possible to export moment or moment API ( e.g. moment.format ).
Now I need to do:

if (iterator.hasNext()) {
    iterator.next()._date.format('...'); // use private attribute
    ...
}

I think more elegant would be call:

iterator.next().format('...')
// or
iterator.next().moment.format('...')
// or something else
@Floriskoch
Copy link

@ph-fuergy I added a PR for this: #201

@harrisiirak
Copy link
Owner

@ph-fuergy @Floriskoch as momentjs itself is now deprecated, we're planning to move away from it (see #195). So yeah, that said, I would avoid adding anything momentjs specific to this library.

I understand that this elegant and convenient way to handle/manipulate data instances, but this isn't really something that belongs to the core functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants