-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mac OS: Support brew installation for Harmony #69
Comments
What is suppose to pack into the bottle? The Harmony CLI? |
Due to the According the Homebrew, Notable enough repo should have >30 forks, >30 watchers and >75 stars. Besides that, when running
A new formula PR is created for homebrew/core: Homebrew/homebrew-core#85856. |
@LeoHChen |
PR for a bug related to Go 1.17 on MacOS: harmony-one/go-sdk#270 Need to figure out what is the issues with arm64, unfortunately, I don't have a M1 Macbook. |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done This issue now has a funding of 3426.2931 ONE (502.66 USD @ $0.15/ONE) attached to it.
|
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work has been started. These users each claimed they can complete the work by 265 years, 1 month from now. 1) cylim has started work.
We can discuss about it at #69 Learn more on the Gitcoin Issue Details page. |
@LeoHChen just in case if you didn't saw my comments ealier, I had summarize to three items. Questions/Note
|
@cylim to package the harmony node program, not just the hmycli |
@LeoHChen which repo is for the node? |
for go-sdk, I am asking for our dev community support to have more star, and forks. |
@LeoHChen All good. The 4 dependencies are all included in one formula. |
your project has many conflicting dependencies. not compilede for mac os.. then nothing of brew. ` honnef.co/go/tools v0.0.1-2020.1.5 // indirect replace github.com/ethereum/go-ethereum => github.com/ethereum/go-ethereum v1.9.9` what? or better: https://github.com/harmony-one/mcl.git https://github.com/harmony-one/bls.git so how to create a precompiled package for mac os if it doesnt compile? |
@GraoMelo The project had passed CI/CD and successfully installed in different MacOS and Linux. The issues we are facing now is there is too many hardcoded path in the Makefile or script files, and Homebrew prefer to do it the Go Module way. |
@jacksteroo - Figured I'd get my feet wet looking at this. In the spirit of eliminating manual processes on the part of the Harmony core team or manual processes with every release, what are your thoughts on: Edit the harmony release github action to:
|
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work for 3426.2931 ONE (1077.45 USD @ $0.34/ONE) has been submitted by:
|
Description
Package our binary, for
brew
. Or in brew terms, "Bottle Harmony One binaries into Brew Casks!". For example,brew install harmony-one
should initiate installation of Harmony binaries alongside all the dependencies. Also allow the installation to be pinned to a certain version.Context
This encourages ease of development and testing, and further helps with decentralizing the ecosystem. See Brew documentation for more info.
Acceptance Criteria
brew
repobrew
guidelines (e.g. permissions, install path, etc.)brew
repobrew
(and Harmony if needed) and review with the Harmony teamReward
USD $500 (in ONEs)
The text was updated successfully, but these errors were encountered: