Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve styling #4

Open
hargasinski opened this issue Jun 22, 2016 · 6 comments
Open

improve styling #4

hargasinski opened this issue Jun 22, 2016 · 6 comments

Comments

@hargasinski
Copy link
Owner

No description provided.

@hargasinski
Copy link
Owner Author

note to self: remove import path for modules

@aearly
Copy link

aearly commented Jun 28, 2016

If we want to improve styling, as well as modify the template (for various fixes and adding things like search) would this be a good time to fork the theme?

@aearly
Copy link

aearly commented Jun 28, 2016

Seems we can just copy the minami theme to something like support/jsdoc/theme/ and go from there.

I've spent too much of my career writing custom.csss that override an upstream style that I want to avoid it at all costs. 😵

@hargasinski
Copy link
Owner Author

For the theme, you have to point JSDoc to a local folder (see this). And npm can handle git repos as dependencies/devDependencies, so I can just fork the repo, and point devDependency to the my repo. I guess this would be the best time to do this.

@hargasinski
Copy link
Owner Author

Or yeah, that might be a better idea, just to manage it directly from the async repo.

@hargasinski
Copy link
Owner Author

I just looked into the minami theme repo. It doesn't have any dependencies, and it's licensed under the Apache License, so it should be as simple as copying it to support/jsdoc/theme, and modifying it from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants