-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can someone merge #298? #348
Comments
@hardikvasa |
I've tried twice now but no reply sadly. |
Maybe now is the time, someone should fork this project to another responsory. |
At this point, there are too many patches that haven’t been merged yet. I just had to manually add a string sanitization fix for the filenames that should have been merged months ago as well. It would be reasonable to think of someone else becoming responsible for maintaining this repository from now on. |
yeah filename have problem |
@Joeclinton1
|
@estuhr1206 I have the exact same issue. In the source of the version by @Joeclinton1 offset does not appear to be used. |
look like now it can't click 'SHOW MORE' when you reached end of page so only
|
@estuhr1206 @jeroenvuurens I've never used offset so I'm not sure what it does. But if it's not in the source code of my patch then it wasn't in the original version I forked. They haven't pushed any changes for a long time so it likely wasn't a feature from the start. You're free to fork my version and add offset if you want. I'll merge your changes if you do that. |
with python 3.8 now it have
|
Same here with python 3.6.8 when trying to download more than 100 images. |
It was fixed with Joeclinton1#8 |
@Joeclinton1 since yours is the most active fork would you consider allowing issues to be opened against it? I feel like it's safe to say that @hardikvasa has abandoned the project and hasn't had any github activity in over a year |
@hellocatfood I added issues to it, hope this helps! |
I am using code derived from google-images-download for a few years now. Google changes their backend frequently, so that whatever you do to make it work, is not very likely to still work after six month. It would be nice if there is a community that keeps this library updated, but if it isn't and you cannot rely on it, you may be better off writing your own code. |
Hi everyone,
more than a year ago now, I pushed a PR to update google-images-download to work with the new google images data format but it still hasn't been merged.
I see people having the same issue over and over and It would be great if people could use the patch by default instead of me having to refer people to it.
Thanks.
The text was updated successfully, but these errors were encountered: