Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConfigDir on MacOSX #34

Closed
flsobral opened this issue Jul 8, 2020 · 2 comments · Fixed by #35
Closed

ConfigDir on MacOSX #34

flsobral opened this issue Jul 8, 2020 · 2 comments · Fixed by #35
Assignees
@harawata
Milestone
1.2.0

Comments

@flsobral
Copy link

flsobral commented Jul 8, 2020

Shouldn't it point to Library/Preferences instead of Library/Application Support?

Since the preferences folder isn't removed when the application is uninstalled and can be migrated when upgrading the Mac, I think it makes sense to store user configuration inside this folder instead of Application Support, that is also available using DataDir.
@harawata harawata added this to the 1.2.0 milestone Jul 9, 2020
@harawata harawata self-assigned this Jul 9, 2020
@harawata
Copy link
Owner

harawata commented Jul 9, 2020

Hello @flsobral ,

It seems that the original python module made the suggested change a while ago.
ActiveState/appdirs#100

I'll make the change and release 1.2.0.
Thank you for taking the time to report!

@harawata harawata mentioned this issue Jul 9, 2020
Merged
@harawata
Copy link
Owner

@flsobral ,

1.2.0 is published on the Maven Central (it's not listed ATM, but it will be) and the release page.
Thanks again for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@harawata harawata

Labels
None yet
Projects
None yet
Milestone
1.2.0
Development

Successfully merging a pull request may close this issue.

Change macOS user/site config dir from 'Application Support' to 'Preferences' harawata/appdirs
2 participants
@harawata @flsobral