Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/throwing errors if required argument is omitted #2859

Conversation

trizotti
Copy link
Contributor

@trizotti trizotti commented Oct 7, 2022

Fix for #2729

lib/types/number.js Outdated Show resolved Hide resolved
@trizotti trizotti marked this pull request as draft October 13, 2022 13:26
@trizotti trizotti requested a review from Marsup October 13, 2022 17:51
@Marsup Marsup self-assigned this Oct 13, 2022
@Marsup Marsup added the bug Bug or defect label Oct 13, 2022
@Marsup Marsup marked this pull request as ready for review October 13, 2022 19:56
@Marsup Marsup added this to the 17.6.4 milestone Oct 13, 2022
@Marsup Marsup merged commit d07463b into hapijs:master Oct 13, 2022
@Marsup
Copy link
Collaborator

Marsup commented Oct 13, 2022

Thanks!

@trizotti trizotti deleted the fix/throwing-errors-if-required-argument-is-omitted branch October 13, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug or defect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some validation methods don't throw an error when their required argument is omitted
2 participants