Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: change validateAsync return type to match options #2838

Merged
merged 1 commit into from Sep 21, 2022
Merged

feat: change validateAsync return type to match options #2838

merged 1 commit into from Sep 21, 2022

Conversation

Marsup
Copy link
Collaborator

@Marsup Marsup commented Sep 17, 2022

Follow-up to #2819

@Marsup Marsup self-assigned this Sep 17, 2022
@Marsup Marsup added the types TypeScript type definitions label Sep 17, 2022
@Marsup Marsup added this to the 17.6.1 milestone Sep 17, 2022
@Marsup Marsup force-pushed the feat/validate-async-types branch 2 times, most recently from 5f0c909 to 6b58c1f Compare September 18, 2022 16:54
@Nargonath
Copy link
Member

I ran the code in this PR with our codebase that uses both manual validateAsync and validate. I was able to run tests and build just fine, no errors in the horizon.

@Marsup Marsup merged commit 96bbfdd into master Sep 21, 2022
@Marsup Marsup deleted the feat/validate-async-types branch September 21, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nargonath Nargonath Nargonath left review comments

Assignees

@Marsup Marsup

Labels
types TypeScript type definitions
Projects
None yet
Milestone
17.6.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Marsup @Nargonath