Latest release break webpack because of class field declarations

[alan-agius4]

Support plan

• which support plan is this issue covered by? (e.g. Community, Core, Plus, or Enterprise): n/a
• is this issue currently blocking your project? (yes/no): yes, because we will be unable to update Angular universal to use the latest @hapi/inerit build: update @hapi/inert to version 6.0.3 angular/universal#1434
• is this issue affecting a production system? (yes/no):

Context

• node version: 12.12
• module version with issue: 16.1.8
• last module version without issue: Not sure, which version introduced ES6 class field declarations.
• environment (e.g. node, browser, native): node
• used with (e.g. hapi application, another framework, standalone, ...): with webpack
• any other relevant information: Also raised this issue with webpack You may need an appropriate loader to handle this file type - when ES6 classes contain public or private field declarations webpack/webpack#10216

What are you trying to achieve or the steps to reproduce?

Try to bundle with @hapijs/joi.

What was the result you got?

ERROR in ./node_modules/@hapi/inert/node_modules/@hapi/joi/lib/errors.js 246:10
[0] Module parse failed: Unexpected token (246:10)
[0] You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
[0] | exports.ValidationError = class extends Error {
[0] | 
[0] >     isJoi = true;
[0] |     name = 'ValidationError';
[0] | 
[0] 
[0] ERROR in ./node_modules/@hapi/inert/node_modules/@hapi/joi/lib/base.js 27:16
[0] Module parse failed: Unexpected token (27:16)
[0] You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
[0] | internals.Base = class {
[0] | 
[0] >     isImmutable = true;                             // Prevents Hoek from deep cloning schema objects
[0] | 
[0] |     constructor(type) {

What result did you expect?

That it works, maybe until webpack supports ES6 class fields declarations, revert the change?

[Marsup]

Our own joi build works though, could it be your config that's wrong?

[alan-agius4]

Most likely it works in your case because you are down levelling using babel-loader. In my case I am not interesting in down levelling.

[Edgar-P-yan]

This version of joi (17.0.0) also does not work with node < v12 (in my case node v10.16.3), because class field declarations are available only in node > v12.x

[Marsup]

This version of joi (17.0.0) also does not work with node < v12 (in my case node v10.16.3), because class field declarations are available only in node > v12.x

Well yes, it's explicitly written in the breaking changes, don't bump without reading what breaks.

[Marsup]

@alan-agius4 is it a problem to stick to 16 anyway? No one is forcing you to upgrade if you're not ready.

[hueniverse]

It is clearly documents and released as a major. This is how JS works - you use the versions of things that fit your setup.