Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove strip from defaults now that it has been removed #1801

Merged
merged 1 commit into from May 8, 2019

Conversation

lerouxb
Copy link
Contributor

@lerouxb lerouxb commented Apr 30, 2019

This commit seems to have broken something: #1714

Well. once 15.0.1 went out.

"strip" is not allowed

at internals.Alternatives.checkOptions (/mnt/project/node_modules/@hapi/joi/lib/types/any/index.js:105:19)
at internals.Alternatives._validateWithOptions (/mnt/project/node_modules/@hapi/joi/lib/types/any/index.js:758:18)
at internals.Alternatives.validate (/mnt/project/node_modules/@hapi/joi/lib/types/any/index.js:797:21)
at type.validate (/mnt/project/lib/by-document/lookup.js:82:123)
at type.validate (/mnt/project/node_modules/@hapi/joi/lib/index.js:394:54)
at type._validate (/mnt/project/node_modules/@hapi/joi/lib/types/any/index.js:676:35)
at internals.Array._checkItems (/mnt/project/node_modules/@hapi/joi/lib/types/array/index.js:245:37)
at internals.Array._base (/mnt/project/node_modules/@hapi/joi/lib/types/array/index.js:81:34)
at internals.Array._validate (/mnt/project/node_modules/@hapi/joi/lib/types/any/index.js:636:31)
at internals.Array._validateWithOptions (/mnt/project/node_modules/@hapi/joi/lib/types/any/index.js:762:29)
at internals.Array.validate (/mnt/project/node_modules/@hapi/joi/lib/types/any/index.js:797:21)
... our code goes here ...

This seems to fix it.

@lerouxb
Copy link
Contributor Author

lerouxb commented Apr 30, 2019

I spent quite a bit of time to try and come up with a minimal test case that fails and I still haven't found it. No idea why all the tests pass but our app breaks.

@Marsup Marsup self-assigned this May 8, 2019
@Marsup Marsup added the bug Bug or defect label May 8, 2019
@Marsup Marsup added this to the 15.0.2 milestone May 8, 2019
@Marsup
Copy link
Collaborator

Marsup commented May 8, 2019

Thanks ! And sorry it took so long !

@Marsup Marsup merged commit ea9facf into hapijs:master May 8, 2019
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug or defect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants