Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper translations for default auth behavior #462

Open
1 of 4 tasks
Nargonath opened this issue Apr 16, 2021 · 2 comments
Open
1 of 4 tasks

Add proper translations for default auth behavior #462

Nargonath opened this issue Apr 16, 2021 · 2 comments
Labels
documentation Non-code related changes help wanted Feel free to open a PR

Comments

@Nargonath
Copy link
Member

Nargonath commented Apr 16, 2021

Context

  • node version: n/a
  • module version: latest

What are you trying to achieve or the steps to reproduce ?

An issue was raised #459 which was fixed in this MR #460 regarding a mismatch between the documentation and the actual default auth strategy behavior. It was fixed in english but not in the other languages. This is a follow-up of #461.

This was fixed in english and we need to update the tutorial in other languages. Here are the missing translations:

  • pt-BR
  • ko-KR
  • tr-TR
  • zh-ZN

Any help is appreciated here since the core team cannot work on these translations. If you want to participate just open a PR and mention this issue without Fixes or Closes keywords and we'll tick the related tasks ourselves.

Thank you.

@Nargonath Nargonath added the documentation Non-code related changes label Apr 16, 2021
@Nargonath Nargonath added the help wanted Feel free to open a PR label Apr 19, 2021
@afgallo
Copy link
Contributor

afgallo commented Apr 19, 2021

I can maybe help with pt-BR. Is this what needs to be translated?

Note that all routes will have the default applied to them, even the ones added before server.auth.default() is called.

@Nargonath
Copy link
Member Author

Yes exactly @afgallo, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Non-code related changes help wanted Feel free to open a PR
Projects
None yet
Development

No branches or pull requests

2 participants