Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big cookie size #489

Open
Eomm opened this issue Nov 17, 2022 · 0 comments
Open

Big cookie size #489

Eomm opened this issue Nov 17, 2022 · 0 comments

Comments

@Eomm
Copy link

Eomm commented Nov 17, 2022

Hi,
I would like to understand why the cookie stores the request.query since they are not used furder in the code to accomplish the OAuth1 dance.

The cookie is necessary only to compare the client.temporary(oauth_callback)'s result

bell/lib/oauth.js

Lines 67 to 73 in 9dbf61c

const state = {
token: temp.oauth_token,
secret: temp.oauth_token_secret,
query: request.query
};
h.state(cookie, state);

Do you have any insight?

This leads to having a set-cookie response header (occasionally) very big and the default NGINX config blocks it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant