Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mio dependency #145

Closed
asafigan opened this issue May 26, 2020 · 4 comments · Fixed by #158
Closed

Update mio dependency #145

asafigan opened this issue May 26, 2020 · 4 comments · Fixed by #158

Comments

@asafigan
Copy link

mio version 0.6 depends on deprecated crate. Upgrade to version 0.7.

@hannobraun
Copy link
Owner

Thanks for the the note!

@ids1024
Copy link

ids1024 commented Oct 18, 2020

And likewise, tokio 0.3, which has recently been released.

Updating both seems mostly easy, except for the fact Tokio no longer includes PollEvented in its public API (it no longer exposes it's dependency on mio in the public API in general).

I suppose the solution would be to manually implement AsyncRead and AsyncWrite similarly to how PollEvented does it?

@hannobraun
Copy link
Owner

Thanks, @ids1024. Any pull requests doing such upgrades are definitely welcome. Not sure what the best way to handle PollEvented would be. I still don't have significant experience with the whole async ecosystem (that work has always been driven by contributors).

@ids1024
Copy link

ids1024 commented Oct 26, 2020

I think this could use AsyncFd which was just merged into tokio. So I guess this is waiting on the next minor Tokio release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants