Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify the audit GHA workflow to check only the production dependencies. #8755

Merged
merged 2 commits into from
Sep 28, 2021
Merged

Modify the audit GHA workflow to check only the production dependencies. #8755

merged 2 commits into from
Sep 28, 2021

Conversation

jansiegel
Copy link
Member

@jansiegel jansiegel commented Sep 27, 2021 •
edited

Context

Problem described in #8754.

This PR modifies the npm audit GHA workflow to utilize the --production flag and recreates the package-lock to clear the current npm audit production errors.

Edit: Additionally, after updating package-lock, the memory leak tests started failing, which seems to have been caused by an unsuspected breaking change in some of the webpack's dependencies changing something in the polyfills.

[skip changelog]

How has this been tested?

  • Manually checked the npm audit --production command on the current develop state.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

  1. Modify to npm audit workflow to omit the dev dependencies. #8754

Affected project(s):

  • handsontable
  • @handsontable/angular
  • @handsontable/react
  • @handsontable/vue

Checklist:

@jansiegel jansiegel self-assigned this Sep 27, 2021
@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 27, 2021 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 68bd7fb:

Sandbox Source
vanilla-handsontable-pr Configuration

@jansiegel
Fix an error being thrown after updating the package-lock, which caus…
68bd7fb 
…ed a breaking change in some of the polyfills.
budnix
budnix approved these changes Sep 28, 2021
View reviewed changes
Copy link
Member

@budnix budnix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jansiegel jansiegel merged commit 274af7f into develop Sep 28, 2021
@jansiegel jansiegel deleted the feature/issue-8754 branch September 28, 2021 08:51
jansiegel added a commit that referenced this pull request Sep 28, 2021
@jansiegel
Modify the audit GHA workflow to check only the production dependenci…
43e0a6f 
…es. (#8755)

* - Switch the npm audit script to production in the GHA workflow
- Regenerate the package-lock file.

 #8754

* Fix an error being thrown after updating the package-lock, which caused a breaking change in some of the polyfills.
@jansiegel jansiegel linked an issue Sep 28, 2021 that may be closed by this pull request
Modify to npm audit workflow to omit the dev dependencies. #8754
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@budnix budnix budnix approved these changes

Assignees

@jansiegel jansiegel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modify to npm audit workflow to omit the dev dependencies.
2 participants
@jansiegel @budnix