Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RegExp vulnerability and clean up major code smells #8752

Closed
budnix opened this issue Sep 27, 2021 · 1 comment · Fixed by #8742
Closed

Fix RegExp vulnerability and clean up major code smells #8752

budnix opened this issue Sep 27, 2021 · 1 comment · Fixed by #8742
Assignees
@budnix
Labels
Status: Released

Comments

@budnix
Copy link
Member

budnix commented Sep 27, 2021 •
edited

Description

As the title says the issue is about fixing regular expression vulnerability found in the helper that checks if the value is a numeric value and implementing a GHA workflow with Code Quality tool that requires clean up major code smells.

Your environment

  • Handsontable version: -
  • Browser Name and version: -
  • Operating System: -
@budnix budnix self-assigned this Sep 27, 2021
@budnix budnix mentioned this issue Sep 27, 2021
Merged
11 tasks
@budnix budnix linked a pull request Sep 27, 2021 that will close this issue
Remove major code smells from the source code #8742
Merged
11 tasks
budnix added a commit that referenced this issue Sep 27, 2021
@budnix
Remove major code smells from the source code (#8742)
7323f3d 
The commit removes all major code smells from the source code detected by the
SonarCloud tool. Additionally, the commit fixes regular expression (marked as
"risk") responsible for detecting numeric values. The expression causes
performance degradation when an empty string is passed.

Issue: #8752
budnix added a commit that referenced this issue Sep 28, 2021
@budnix
Remove major code smells from the source code (#8742)
aa7653c 
The commit removes all major code smells from the source code detected by the
SonarCloud tool. Additionally, the commit fixes regular expression (marked as
"risk") responsible for detecting numeric values. The expression causes
performance degradation when an empty string is passed.

Issue: #8752
@AMBudnik
Copy link
Contributor

Released in Handsontable v10.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@budnix budnix

Labels
Status: Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove major code smells from the source code handsontable/handsontable
2 participants
@budnix @AMBudnik