Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a default font size, color and family #8661

Closed
krzysztofspilka opened this issue Aug 19, 2021 · 1 comment · Fixed by #8681
Closed

Add a default font size, color and family #8661

krzysztofspilka opened this issue Aug 19, 2021 · 1 comment · Fixed by #8681
Assignees
@budnix
Labels
Breaking change enhancement Status: Released

Comments

@krzysztofspilka
Copy link
Member

krzysztofspilka commented Aug 19, 2021 •
edited

Description

I noticed the inconsistency in CSS properties. For instance, we declare the specific styles of headers, selection, menus, etc. but at the same time, we miss such basic properties as a font-family and font-size.

Our goal is to make sure, that the default instance of Handsontable deployed on a clean page will look attractive without any extra work needed from the developer.

New global styles (make sure they apply to menus - context, column, dropdown) and accessories such as license key notification are provided below:

font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", "Roboto", "Oxygen", "Ubuntu", "Helvetica Neue", Arial, sans-serif;
font-size: 13px
font-weight: normal
color: #373737

Links color (<a>)
color: #104acc

Result preview:

Screen Shot 2021-08-19 at 15 00 50

Consider removing additional styling from code snippets in our docs:
https://github.com/handsontable/handsontable/blob/master/docs/.vuepress/theme/styles/handsontable.styl
@krzysztofspilka krzysztofspilka changed the title Add default font size, color and family Add a default font size, color and family Aug 19, 2021
@budnix budnix self-assigned this Aug 25, 2021
budnix added a commit that referenced this issue Aug 26, 2021
@budnix
Add default font size, color and family
a6a1a66 
Issue: #8661
@budnix budnix mentioned this issue Aug 26, 2021
Merged
11 tasks
@budnix budnix linked a pull request Aug 26, 2021 that will close this issue
Add default font size, color and family #8681
Merged
11 tasks
budnix added a commit that referenced this issue Aug 26, 2021
@budnix
Add changelog entry
e3c88b1 
Issue: #8661
budnix added a commit that referenced this issue Aug 27, 2021
@budnix
Stabilize the tests by overwriting default font-family
fddc4c7 
Issue: #8661
budnix added a commit that referenced this issue Aug 30, 2021
@budnix
Fix test for Win env
ca573af 
Issue: #8661
budnix added a commit that referenced this issue Aug 31, 2021
@budnix
Change the default font for test environment
3b7d337 
Issue: #8661
budnix added a commit that referenced this issue Sep 1, 2021
@budnix
Remove redundant code comment
1c11862 
Issue: #8661
budnix added a commit that referenced this issue Sep 10, 2021
@budnix
Add default font size, color and family (#8681)
a5e560c 
The commit changes the default font-size, font-family, font-weight, and color
for all elements within the `.handsontable` CSS class.
Moreover, the PR updates the puppeteer package that uses the latest Chrome
version. Thanks to that I was able to stabilize the tests and get rid of usage
(from some places) of the `toBeArountValue` jasmine matches. The previously
installed version of the puppeteer uses Chrome v80, now it's v93.

Issue: #8661
@AMBudnik
Copy link
Contributor

Changed in Handsontable v10

@AMBudnik AMBudnik mentioned this issue Sep 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@budnix budnix

Labels
Breaking change enhancement Status: Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add default font size, color and family handsontable/handsontable
3 participants
@budnix @krzysztofspilka @AMBudnik