Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Research the possibility of moving the CI setup to Github Actions. #8652

Closed
jansiegel opened this issue Aug 19, 2021 · 1 comment · Fixed by #8653
Closed

Research the possibility of moving the CI setup to Github Actions. #8652

jansiegel opened this issue Aug 19, 2021 · 1 comment · Fixed by #8653
Assignees
@jansiegel
Labels
Status: Released Type: Improvement suggestion

Comments

@jansiegel
Copy link
Member

Description

We should check if moving our current CI setup to Github Actions is feasible and beneficial (time- and cost-wise).
@jansiegel jansiegel self-assigned this Aug 19, 2021
@jansiegel jansiegel mentioned this issue Aug 19, 2021
Merged
11 tasks
@jansiegel jansiegel linked a pull request Aug 19, 2021 that will close this issue
Create an GH Actions workflow covering testing of Handsontable and the wrappers. #8653
Merged
11 tasks
jansiegel added a commit that referenced this issue Sep 20, 2021
@jansiegel
Extend the handsontable-related paths in the testing workflow. #8652
ba8885c
jansiegel added a commit that referenced this issue Sep 20, 2021
@jansiegel
- Add test paths to the test workflow whitelist. #8652
e93a57f
jansiegel added a commit that referenced this issue Sep 20, 2021
@jansiegel
- Add tests' script path to test workflow's whitelist. #8652
2c4b7fc
jansiegel added a commit that referenced this issue Sep 20, 2021
@jansiegel
- Add the e2e test paths + tests' script path to the test workflow's …
fb471c5 
…whitelist for the UMD build. #8652
jansiegel added a commit that referenced this issue Sep 20, 2021
@jansiegel
Add a changelog entry for #8652.
16b3627
jansiegel added a commit that referenced this issue Sep 21, 2021
@jansiegel
- Remove two triggers from the testing workflow
e784355 
- Correct typo in the testing workflow
 #8652
jansiegel added a commit that referenced this issue Sep 22, 2021
@jansiegel
- Apply post-CR suggestions
698604c 
- Remove the 'skip-all' logic, as it's no longer needed
- Replace the codeship badge with the GHA badge in README
 #8652
jansiegel added a commit that referenced this issue Sep 23, 2021
@jansiegel
- Rearrange the 'path-filter' config and fix post CR-issues
5fd0126 
- Movie the unit tests to be run alongside the HOT build
 #8652
jansiegel added a commit that referenced this issue Sep 24, 2021
@jansiegel
- Add 'babel.config.js' and 'hot.config.js' to the config files path …
48bb97f 
…whitelist

- Move the unit testing to be run without waiting on the HOT build
 #8652
jansiegel added a commit that referenced this issue Sep 24, 2021
@jansiegel
Change the node version to 15.x #8652
a7a7bae
jansiegel added a commit that referenced this issue Sep 24, 2021
@jansiegel
Create an GH Actions workflow covering testing of Handsontable and th…
5e52e7a 
…e wrappers. (#8653)

* Add a test workflow and some required/test changes.

* Extend the handsontable-related paths in the testing workflow. #8652

* - Add test paths to the test workflow whitelist. #8652

* - Add tests' script path to test workflow's whitelist. #8652

* - Add the e2e test paths + tests' script path to the test workflow's whitelist for the UMD build. #8652

* Add a changelog entry for #8652.

* - Remove two triggers from the testing workflow
- Correct typo in the testing workflow
 #8652

* - Apply post-CR suggestions
- Remove the 'skip-all' logic, as it's no longer needed
- Replace the codeship badge with the GHA badge in README
 #8652

* - Add 'opened' and 'reopened' to the pull_request triggers.

* - Rearrange the 'path-filter' config and fix post CR-issues
- Movie the unit tests to be run alongside the HOT build
 #8652

* - Add 'babel.config.js' and 'hot.config.js' to the config files path whitelist
- Move the unit testing to be run without waiting on the HOT build
 #8652

* Change the node version to 15.x #8652

* - Cleanup after previous changes
@jansiegel
Copy link
Member Author

jansiegel commented Sep 24, 2021 •
edited

Summary notes

  • After merging Create an GH Actions workflow covering testing of Handsontable and the wrappers. #8653 to the develop branch, all the tests are being run by the Github Actions environment, and are marked as required.

  • Before this, all the tests were run on Codeship, and because of the inability to precisely determine the merge base of the pull requests (without using the Github API), the "targeted testing" script was replaced with a setup that triggered all tests (UMD + UMD.min + Unit + Types + wrappers), split between 2 pipelines.

  • After the change, the workflow responsible for triggering the tests recognizes what files were modified in a pull request, and determines which tests should be triggered based on their paths.

  • All of the test/build scenarios that are independent from anothers are being performed in parallel:
    image

  • The testing workflow is triggered by:

    • The push event for the following branches:
      • master
      • develop
      • release/**
    • The pull_request event for every other branch.
    • After the changes are merged to master (with the next release), it will be possible to trigger the workflow manually.

  • As for the difference in the duration of the tests, it's difficult to calculate the exact time saved by this PR, but in the case of the 049af94 commit:

  • The Codeship integration was marked as suspended, and if the new setup works alright, will be removed in the nearest future.

cc: @krzysztofspilka @wojciechczerniak

jansiegel added a commit that referenced this issue Sep 28, 2021
@jansiegel
Create an GH Actions workflow covering testing of Handsontable and th…
82f9869 
…e wrappers. (#8653)

* Add a test workflow and some required/test changes.

* Extend the handsontable-related paths in the testing workflow. #8652

* - Add test paths to the test workflow whitelist. #8652

* - Add tests' script path to test workflow's whitelist. #8652

* - Add the e2e test paths + tests' script path to the test workflow's whitelist for the UMD build. #8652

* Add a changelog entry for #8652.

* - Remove two triggers from the testing workflow
- Correct typo in the testing workflow
 #8652

* - Apply post-CR suggestions
- Remove the 'skip-all' logic, as it's no longer needed
- Replace the codeship badge with the GHA badge in README
 #8652

* - Add 'opened' and 'reopened' to the pull_request triggers.

* - Rearrange the 'path-filter' config and fix post CR-issues
- Movie the unit tests to be run alongside the HOT build
 #8652

* - Add 'babel.config.js' and 'hot.config.js' to the config files path whitelist
- Move the unit testing to be run without waiting on the HOT build
 #8652

* Change the node version to 15.x #8652

* - Cleanup after previous changes
jansiegel added a commit that referenced this issue Oct 6, 2021
@jansiegel
Create an GH Actions workflow covering testing of Handsontable and th…
6de4fbb 
…e wrappers. (#8653)

* Add a test workflow and some required/test changes.

* Extend the handsontable-related paths in the testing workflow. #8652

* - Add test paths to the test workflow whitelist. #8652

* - Add tests' script path to test workflow's whitelist. #8652

* - Add the e2e test paths + tests' script path to the test workflow's whitelist for the UMD build. #8652

* Add a changelog entry for #8652.

* - Remove two triggers from the testing workflow
- Correct typo in the testing workflow
 #8652

* - Apply post-CR suggestions
- Remove the 'skip-all' logic, as it's no longer needed
- Replace the codeship badge with the GHA badge in README
 #8652

* - Add 'opened' and 'reopened' to the pull_request triggers.

* - Rearrange the 'path-filter' config and fix post CR-issues
- Movie the unit tests to be run alongside the HOT build
 #8652

* - Add 'babel.config.js' and 'hot.config.js' to the config files path whitelist
- Move the unit testing to be run without waiting on the HOT build
 #8652

* Change the node version to 15.x #8652

* - Cleanup after previous changes
@AMBudnik AMBudnik mentioned this issue Nov 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jansiegel jansiegel

Labels
Status: Released Type: Improvement suggestion
Projects
None yet
Milestone
No milestone
2 participants
@jansiegel @AMBudnik